Re: [PATCH 07/10] [media] tvp5150: Add device tree binding document
From: Laurent Pinchart <hidden>
Date: 2016-01-06 11:08:33
Also in:
linux-media, lkml
Hi Javier, Thank you for the patch. On Monday 04 January 2016 09:25:29 Javier Martinez Canillas wrote:
quoted hunk ↗ jump to hunk
Add a Device Tree binding document for the TVP5150 video decoder. Signed-off-by: Javier Martinez Canillas <redacted> --- .../devicetree/bindings/media/i2c/tvp5150.txt | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/tvp5150.txtdiff --git a/Documentation/devicetree/bindings/media/i2c/tvp5150.txtb/Documentation/devicetree/bindings/media/i2c/tvp5150.txt new file mode 100644 index 000000000000..bf0b3f3128ce--- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/tvp5150.txt@@ -0,0 +1,35 @@ +* Texas Instruments TVP5150 and TVP5151 video decoders + +The TVP5150 and TVP5151 are video decoders that convert baseband NTSC andPAL +(and also SECAM in the TVP5151 case) video signals to either 8-bit 4:2:2 YUV +with discrete syncs or 8-bit ITU-R BT.656 with embedded syncs output formats. + +Required Properties: +- compatible: value must be "ti,tvp5150" +- reg: I2C slave address + +Optional Properties: +- powerdown-gpios: phandle for the GPIO connected to the PDN pin, if any.
The signal is called PDN in the datasheet, so it might make sense to call this pdn-gpios. I have no strong opinion on this, I'll let you decide what you think is best. Apart from that (and the indentation issue pointed out by Rob), Reviewed-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
+- reset-gpios: phandle for the GPIO connected to the RESETB pin, if any.
+
+The device node must contain one 'port' child node for its digital output
+video port, in accordance with the video interface bindings defined in
+Documentation/devicetree/bindings/media/video-interfaces.txt.
+
+Example:
+
+&i2c2 {
+ ...
+ tvp5150@5c {
+ compatible = "ti,tvp5150";
+ reg = <0x5c>;
+ powerdown-gpios = <&gpio4 30 GPIO_ACTIVE_LOW>;
+ reset-gpios = <&gpio6 7 GPIO_ACTIVE_LOW>;
+
+ port {
+ tvp5150_1: endpoint {
+ remote-endpoint = <&ccdc_ep>;
+ };
+ };
+ };
+};-- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html