Re: [PATCH v3 3/6] DT: PCI: qcom: Document PCIe devicetree bindings

Thanks for the comments!

On 11/24/2015 01:17 AM, Rob Herring wrote:

On Mon, Nov 23, 2015 at 11:29:00AM +0200, Stanimir Varbanov wrote:

quoted

From: Stanimir Varbanov <redacted>

Document Qualcomm PCIe driver devicetree bindings.

Signed-off-by: Stanimir Varbanov <redacted>
Signed-off-by: Stanimir Varbanov <redacted>
---
 .../devicetree/bindings/pci/qcom,pcie.txt          |  231 ++++++++++++++++++++
 1 file changed, 231 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/qcom,pcie.txt

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
new file mode 100644
index 000000000000..d7640d45fa31
--- /dev/null
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt

@@ -0,0 +1,231 @@
+* Qualcomm PCI express root complex
+
+- compatible:
+	Usage: required
+	Value type: <stringlist>
+	Definition: Value shall include
+		    - "qcom,pcie-v0" for apq/ipq8064
+		    - "qcom,pcie-v1" for apq8084

Use chip part numbers, not versions.

Sure.

Also, shouldn't you have the Designware compatible in addition.

[...]

quoted

+
+- <name>-gpio:

Use -gpios

Ok I will.

-- 
regards,
Stan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html