Thread (19 messages) 19 messages, 7 authors, 2015-11-24

Re: [PATCH v3 3/6] DT: PCI: qcom: Document PCIe devicetree bindings

From: Rob Herring <robh@kernel.org>
Date: 2015-11-23 23:17:52
Also in: linux-arm-kernel, linux-arm-msm, linux-pci, lkml

On Mon, Nov 23, 2015 at 11:29:00AM +0200, Stanimir Varbanov wrote:
quoted hunk ↗ jump to hunk
From: Stanimir Varbanov <redacted>

Document Qualcomm PCIe driver devicetree bindings.

Signed-off-by: Stanimir Varbanov <redacted>
Signed-off-by: Stanimir Varbanov <redacted>
---
 .../devicetree/bindings/pci/qcom,pcie.txt          |  231 ++++++++++++++++++++
 1 file changed, 231 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/qcom,pcie.txt
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
new file mode 100644
index 000000000000..d7640d45fa31
--- /dev/null
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
@@ -0,0 +1,231 @@
+* Qualcomm PCI express root complex
+
+- compatible:
+	Usage: required
+	Value type: <stringlist>
+	Definition: Value shall include
+		    - "qcom,pcie-v0" for apq/ipq8064
+		    - "qcom,pcie-v1" for apq8084
Use chip part numbers, not versions.

Also, shouldn't you have the Designware compatible in addition.

[...]
+
+- <name>-gpio:
Use -gpios
+	Usage: optional
+	Value type: <prop-encoded-array>
+	Definition: List of phandle and gpio specifier pairs. Should contain
+		    - "perst"  PCIe endpoint reset signal line
+		    - "pewake" PCIe endpoint wake signal line
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help