On 8/12/2015 3:56 AM, Simon Horman wrote:

quoted

The "compatible" property text contradicts even the example given in the MMCIF
binding document itself;  moreover, the Renesas MMCIF driver only matches on
the generic "compatible" string and doesn't look for the SoC specific strings
at all. Thus describe "renesas,sh-mmcif" as a fallback value.

quoted

Fixes: b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")
Signed-off-by: Sergei Shtylyov <redacted>

I don't believe this file is the appropriate place to describe
best-practice for the ordering of compatible strings which must surely be
documented elsewhere.

    Where? I have no idea what you mean...
    And let me reiterate: this text is *wrong* and needs to be fixed anyway.

quoted

---
The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' and 'next' branches.

Changes in version 2:
- kept the SoC specific "compatible" property values mandatory and made the
   generic string a fallback.

  Documentation/devicetree/bindings/mmc/renesas,mmcif.txt |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Index: mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
===================================================================

--- mmc.orig/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
+++ mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt

@@ -10,7 +10,7 @@ Required properties:
  	- "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
  	- "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
  	- "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
-	- "renesas,sh-mmcif" for the generic MMCIF
+  followed by "renesas,sh-mmcif".

 >>

quoted

  - clocks: reference to the functional clock

MBR, Sergei