Re: [PATCH v2] DT: mmc: sh_mmcif: fix "compatible" property text
From: Simon Horman <horms@verge.net.au>
Date: 2015-08-12 00:56:28
Also in:
linux-mmc, linux-sh
Hi Sergei, On Wed, Aug 12, 2015 at 01:37:28AM +0300, Sergei Shtylyov wrote:
The "compatible" property text contradicts even the example given in the MMCIF
binding document itself; moreover, the Renesas MMCIF driver only matches on
the generic "compatible" string and doesn't look for the SoC specific strings
at all. Thus describe "renesas,sh-mmcif" as a fallback value.
Fixes: b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")
Signed-off-by: Sergei Shtylyov <redacted>I don't believe this file is the appropriate place to describe best-practice for the ordering of compatible strings which must surely be documented elsewhere.
quoted hunk ↗ jump to hunk
--- The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' and 'next' branches. Changes in version 2: - kept the SoC specific "compatible" property values mandatory and made the generic string a fallback. Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt ===================================================================--- mmc.orig/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +++ mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt@@ -10,7 +10,7 @@ Required properties: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIF + followed by "renesas,sh-mmcif". - clocks: reference to the functional clock --To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html