Thread (20 messages) 20 messages, 3 authors, 2015-08-07

Re: [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe()

From: Kishon Vijay Abraham I <hidden>
Date: 2015-08-05 14:08:21
Also in: linux-omap, lkml

Hi,

On Tuesday 04 August 2015 09:30 PM, Felipe Balbi wrote:
On Tue, Aug 04, 2015 at 08:50:40PM +0530, Kishon Vijay Abraham I wrote:
quoted
No functional change. Add separate functions for pll,
clocks and syscon to make ti_pipe3_probe clean.

Signed-off-by: Kishon Vijay Abraham I <redacted>
I think this needs to be splitted into smaller patches.
yeah sure.

Thanks
Kishon
Seems like the very first patch would be to introduce a local struct
device pointer to be used. Than add each and every new function on their
own patch. This will help big time making your refactoring a lot clearer
and, should anything go wrong, we can atomically revert a specific
change, instead of loosing the entire refactor.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help