Re: [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe()
From: Felipe Balbi <hidden>
Date: 2015-08-04 16:00:37
Also in:
linux-omap, lkml
Attachments
- signature.asc [application/pgp-signature] 819 bytes
From: Felipe Balbi <hidden>
Date: 2015-08-04 16:00:37
Also in:
linux-omap, lkml
On Tue, Aug 04, 2015 at 08:50:40PM +0530, Kishon Vijay Abraham I wrote:
No functional change. Add separate functions for pll, clocks and syscon to make ti_pipe3_probe clean. Signed-off-by: Kishon Vijay Abraham I <redacted>
I think this needs to be splitted into smaller patches. Seems like the very first patch would be to introduce a local struct device pointer to be used. Than add each and every new function on their own patch. This will help big time making your refactoring a lot clearer and, should anything go wrong, we can atomically revert a specific change, instead of loosing the entire refactor. -- balbi