Re: [PATCH V3 03/19] memory: tegra: add flush operation for Tegra30 memory clients
flat view
From: Jon Hunter <hidden>
Date: 2015-07-21 08:54:03
Also in:
linux-arm-kernel, linux-pm, linux-tegra
On 17/07/15 11:03, Thierry Reding wrote:
* PGP Signed by an unknown key On Mon, Jul 13, 2015 at 01:39:41PM +0100, Jon Hunter wrote:quoted
From: Vince Hsu <redacted> This patch adds the hot reset register table and flush related callback functions for Tegra30. Signed-off-by: Vince Hsu <redacted> [jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org: Removed tegra_mc_ops and added metastable_flush_reads.] Signed-off-by: Jon Hunter <redacted> --- v3: removal of tegra_mc_ops --- drivers/memory/tegra/tegra30.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)diff --git a/drivers/memory/tegra/tegra30.c b/drivers/memory/tegra/tegra30.c index 1abcd8f6f3ba..3b4987f39b52 100644 --- a/drivers/memory/tegra/tegra30.c +++ b/drivers/memory/tegra/tegra30.c@@ -6,6 +6,7 @@ * published by the Free Software Foundation. */ +#include <linux/device.h>What do you need this for?
Looks like I forgot to remove this, when removing the tegra_mc_ops. Thanks, will remove.
quoted
#include <linux/of.h> #include <linux/mm.h>@@ -936,6 +937,26 @@ static const struct tegra_smmu_swgroup tegra30_swgroups[] = { { .name = "isp", .swgroup = TEGRA_SWGROUP_ISP, .reg = 0x258 }, }; +static struct tegra_mc_flush tegra30_mc_flush[] = {const
Yes, will fix.
quoted
+ {TEGRA_SWGROUP_AFI, 0x200, 0x204, 0}, + {TEGRA_SWGROUP_AVPC, 0x200, 0x204, 1}, + {TEGRA_SWGROUP_DC, 0x200, 0x204, 2}, + {TEGRA_SWGROUP_DCB, 0x200, 0x204, 3}, + {TEGRA_SWGROUP_EPP, 0x200, 0x204, 4}, + {TEGRA_SWGROUP_G2, 0x200, 0x204, 5}, + {TEGRA_SWGROUP_HC, 0x200, 0x204, 6}, + {TEGRA_SWGROUP_HDA, 0x200, 0x204, 7}, + {TEGRA_SWGROUP_ISP, 0x200, 0x204, 8}, + {TEGRA_SWGROUP_MPCORE, 0x200, 0x204, 9}, + {TEGRA_SWGROUP_MPCORELP, 0x200, 0x204, 10}, + {TEGRA_SWGROUP_MPE, 0x200, 0x204, 11}, + {TEGRA_SWGROUP_NV, 0x200, 0x204, 12}, + {TEGRA_SWGROUP_NV2, 0x200, 0x204, 13}, + {TEGRA_SWGROUP_PPCS, 0x200, 0x204, 14}, + {TEGRA_SWGROUP_VDE, 0x200, 0x204, 16}, + {TEGRA_SWGROUP_VI, 0x200, 0x204, 17},Spaces around { and }, please.
Ok. Cheers Jon