Thread (45 messages) 45 messages, 7 authors, 2015-08-05

Re: [PATCH v2 4/9] arm: twr-k70f120m: timer driver for Kinetis SoC

From: Thomas Gleixner <hidden>
Date: 2015-07-01 13:28:34
Also in: linux-arm-kernel, linux-clk, linux-gpio, linux-serial, lkml

On Wed, 1 Jul 2015, Paul Osmialowski wrote:
Hi Thomas,

On Wed, 1 Jul 2015, Thomas Gleixner wrote:
quoted
quoted
+		clockevents_register_device(
+				&kinetis_clockevent_tmrs[chan].evtdev);
+
+		kinetis_pit_init(&kinetis_clockevent_tmrs[chan],
+						(rate / HZ) - 1);
+		kinetis_pit_enable(&kinetis_clockevent_tmrs[chan], 1);
No point doing this. The core code has invoked the set_periodic call
back via clockevents_register_device() already.
As I removed this kinetis_pit_enable() line, the timer did not start,
therefore the system became unusable. What could be possible reason for that?
Well, you need to move both, the init and the enable into
set_periodic().

Thanks,

	tglx
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help