Re: [PATCH v2 7/9] arm: twr-k70f120m: use Freescale eDMA driver with Kinetis SoC
From: Arnd Bergmann <arnd@arndb.de>
Date: 2015-06-30 20:50:30
Also in:
linux-arm-kernel, linux-clk, linux-gpio, linux-serial, lkml
On Tuesday 30 June 2015 14:27:28 Paul Osmialowski wrote:
Note that <mach/memory.h> is needed (which is denoted by CONFIG_NEED_MACH_MEMORY_H) as it provides macros required for proper operation of DMA allocation functions.
You can't do this, it breaks compilation when multiple platforms are enabled.
quoted hunk ↗ jump to hunk
Signed-off-by: Paul Osmialowski <redacted> --- arch/arm/Kconfig | 4 ++ arch/arm/boot/dts/kinetis.dtsi | 34 ++++++++++++++++ arch/arm/mach-kinetis/include/mach/memory.h | 61 +++++++++++++++++++++++++++++ 3 files changed, 99 insertions(+) create mode 100644 arch/arm/mach-kinetis/include/mach/memory.hdiff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index b21592b..8ccffee 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig@@ -971,6 +971,10 @@ config ARCH_KINETIS select CLKSRC_KINETIS select PINCTRL select PINCTRL_KINETIS + select DMADEVICES + select FSL_EDMA + select DMA_OF + select NEED_MACH_MEMORY_H
I think DMA_OF is implied by dmaengine support in combination with CONFIG_OF
+ +#ifndef _MACH_KINETIS_MEMORY_H +#define _MACH_KINETIS_MEMORY_H + +#ifndef __ASSEMBLY__ + +/* + * On Kinetis K70, consistent DMA memory resides in a special + * DDRAM alias region (non-cacheable DDRAM at 0x80000000). + * + */ +#define KINETIS_PHYS_DMA_OFFSET UL(0x80000000) + +/* + * Mask of the field used to distinguish DDRAM aliases + */ +#define KINETIS_DRAM_ALIAS_MASK UL(0xf8000000)
This should be expressed using the 'dma-ranges' properties in the bus nodes above any DMA master, the normal DMA mapping code will then do the right thing. Arnd