Thread (42 messages) 42 messages, 6 authors, 2015-05-11

Re: [PATCH 03/12] clocksource: sti: Provide 'use timer as sched clock' capability

From: Daniel Lezcano <hidden>
Date: 2015-05-11 08:47:50
Also in: linux-arm-kernel, linux-rtc, linux-watchdog, lkml

On 05/08/2015 01:47 PM, Paul Bolle wrote:
On Fri, 2015-05-08 at 11:29 +0100, Lee Jones wrote:
quoted
Ah, you mean from menuconfig.  I almost forgot what that was. ;)

I can add a menu option, no problem.
It's not just menuconfig:
     $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config
     CONFIG_ARCH_STI=y
     CONFIG_CLKSRC_ST_LPC=y
     CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK=y
     $ vim .config
     $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config
     CONFIG_ARCH_STI=y
     # CONFIG_CLKSRC_ST_LPC is not set
     # CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK is not set
     $ make ARCH=arm silentoldconfig
     scripts/kconfig/conf  --silentoldconfig Kconfig
     #
     # configuration written to .config
     #
     $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config
     CONFIG_ARCH_STI=y
     CONFIG_CLKSRC_ST_LPC=y
     CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK=y

So I think that, if you want to be able to set
CLKSRC_ST_LPC_TIMER_SCHED_CLOCK to 'n' even though CLKSRC_ST_LPC is 'y',
you need to add a prompt. Or have you found a way around this?
The general policy is to have non-prompted options in the clocksource's 
Kconfig and let the platform's config to select the right components.


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help