Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()
From: Peter Hurley <hidden>
Date: 2015-03-06 19:00:05
Also in:
linux-arm-kernel, lkml
Subsystem:
open firmware and flattened device tree, the rest · Maintainers:
Rob Herring, Saravana Kannan, Linus Torvalds
On 03/06/2015 01:11 PM, Peter Hurley wrote:
On 03/06/2015 11:52 AM, Leif Lindholm wrote:
[...]
quoted
Could you give the below a spin, and if it works for you, send me the above tests as a full patch so that I can post both as a series?Will do as soon as I finish testing.
All passed with your patch; patch for testcases below. Regards, Peter Hurley
--- >% ---From: Peter Hurley <redacted> Subject: [PATCH] of: unittest: Add options string testcase variants Add testcase variants with '/' in the options string to test for scan beyond end path name terminated by ':'. Signed-off-by: Peter Hurley <redacted> --- drivers/of/unittest.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 0cf9a23..b2d7547 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c@@ -92,6 +92,11 @@ static void __init of_selftest_find_node_by_name(void) "option path test failed\n"); of_node_put(np); + np = of_find_node_opts_by_path("/testcase-data:test/option", &options); + selftest(np && !strcmp("test/option", options), + "option path test, subcase #1 failed\n"); + of_node_put(np); + np = of_find_node_opts_by_path("/testcase-data:testoption", NULL); selftest(np, "NULL option path test failed\n"); of_node_put(np);
@@ -102,6 +107,12 @@ static void __init of_selftest_find_node_by_name(void) "option alias path test failed\n"); of_node_put(np); + np = of_find_node_opts_by_path("testcase-alias:test/alias/option", + &options); + selftest(np && !strcmp("test/alias/option", options), + "option alias path test, subcase #1 failed\n"); + of_node_put(np); + np = of_find_node_opts_by_path("testcase-alias:testaliasoption", NULL); selftest(np, "NULL option alias path test failed\n"); of_node_put(np);
--
2.3.1