Re: [PATCH v3 1/3] devicetree: of: Add bindings for chosennode, stdout-path
From: Grant Likely <hidden>
Date: 2014-11-28 00:22:28
Also in:
linux-arm-kernel, lkml
On Thu, 27 Nov 2014 18:41:33 +0000 , Mark Rutland [off-list ref] wrote:
On Thu, Nov 27, 2014 at 05:56:05PM +0000, Leif Lindholm wrote:quoted
Add a global binding for the chosen node. Include a description of the stdout-path, and an explicit statement on its extra options in the context of a UART console. Opening description stolen from www.devicetree.org, and part of the remaining text provided by Mark Rutland. Signed-off-by: Leif Lindholm <redacted> --- Documentation/devicetree/bindings/chosen.txt | 42 ++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/chosen.txtdiff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt new file mode 100644 index 0000000..9cd74e9 --- /dev/null +++ b/Documentation/devicetree/bindings/chosen.txt@@ -0,0 +1,42 @@ +The chosen node +--------------- + +The chosen node does not represent a real device, but serves as a place +for passing data between firmware and the operating system, like boot +arguments. Data in the chosen node does not represent the hardware. + + +stdout-path property +-------------------- + +Device trees may specify the device to be used for boot console output +with a stdout-path property under /chosen, as described in ePAPR, e.g. + +/ { + chosen { + stdout-path = "/serial@f00:115200"; + }; + + serial@f00 { + compatible = "vendor,some-uart"; + reg = <0xf00 0x10>; + }; +}; + +If the character ":" is present in the value, this terminates the path. +The meaning of any characters following the ":" is device-specific, and +must be specified in the relevant binding documentation. + +For UART devices, the format supported by uart_parse_options() is the +expected one. In this case, the format of the string is:Please drop the mention of uart_parse_options and just describe the format. Linux internal details are irrelevant to the contract of the binding. Otherwise this looks good to me!
I've fixed it up and merged it. No need to respin. Thanks! g.