Re: [PATCH] Add attributes neccessary for LED flashes to devicetree/bindings/leds/common.txt
From: Pavel Machek <hidden>
Date: 2014-12-03 18:58:22
Also in:
linux-leds
On Tue 2014-11-25 22:09:49, Bryan Wu wrote:
On Mon, Nov 24, 2014 at 2:53 PM, Pavel Machek [off-list ref] wrote:quoted
On Fri 2014-11-21 09:15:31, Jacek Anaszewski wrote:quoted
Hi Pavel, On 11/20/2014 09:52 PM, Pavel Machek wrote:quoted
On Thu 2014-11-20 15:48:26, Jacek Anaszewski wrote:quoted
On 11/20/2014 02:38 PM, Jacek Anaszewski wrote:quoted
Hi Pavel, On 11/20/2014 02:17 PM, Pavel Machek wrote:quoted
Add attributes neccessary for LED flashes to devicetree/bindings/leds/common.txt . This will allow me to add device tree support for adp1653 i2c flash LED driver, and allow Jacek Anaszewski to add support for more LED drivers....quoted
Actually, we've agreed with Sakari that we can handle indicator-pattern later.Good.quoted
I would remove references to you, me and adp1653 driver from the commit message and mention that this modifications adjust the led common bindings to the LED Flash class that is to be added.Ok, who can take this patch? Can you edit the changelog, or should I do it? Anything else that needs changing?It's your patch :) For me the contents of the patch are ok. It requires device tree maintainer approval anyway.Yeah, I was hoping relevant maintainers would speak up. I was not asking you to edit the changelog, sorry I was unclear. Bryan Wu, Richard Purdie: You are the maintainers. Can you take the patch?I'm OK for this patch, but since Jacek and Sakari are working on pushing LED Flash class and driver into our LED subsystem. I need you guys' Ack for this. Then I can take it in my tree.
Ok, patch with the 2 acks is now waiting in your inbox :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html