Re: [PATCH] Add attributes neccessary for LED flashes to devicetree/bindings/leds/common.txt
From: Sakari Ailus <sakari.ailus@iki.fi>
Date: 2014-12-03 16:03:52
Also in:
linux-leds
Hi Jacek, On Fri, Nov 21, 2014 at 08:38:33AM +0100, Jacek Anaszewski wrote:
Hi Pavel, Sakari, On 11/20/2014 04:03 PM, Sakari Ailus wrote:quoted
Hi Pavel, On Thu, Nov 20, 2014 at 02:17:13PM +0100, Pavel Machek wrote:quoted
Add attributes neccessary for LED flashes to devicetree/bindings/leds/common.txt . This will allow me to add device tree support for adp1653 i2c flash LED driver, and allow Jacek Anaszewski to add support for more LED drivers.. Signed-off-by: Pavel Machek <redacted>diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt index 2d88816..e9acbbc 100644 --- a/Documentation/devicetree/bindings/leds/common.txt +++ b/Documentation/devicetree/bindings/leds/common.txt@@ -14,6 +14,15 @@ Optional properties for child nodes: "ide-disk" - LED indicates disk activity "timer" - LED flashes at a fixed, configurable rate +- max-microamp : maximum intensity in microamperes of the LED + (torch LED for flash devices) +- flash-max-microamp : maximum intensity in microamperes of the + flash LED; it is mandatory if the LED should + support the flash mode +- flash-timeout-microsec : timeout in microseconds after which the flash + LED is turned offIt might be good to add a note that these may be arrays, depending on the device.This binding is for a sub-node representing a single led. Do you know devices which would require an array of max currents for a sub-led?
Oops, I missed to reply to this one. No, if this is just a single LED then I think it's fine. -- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk