Thread (106 messages) 106 messages, 7 authors, 2014-11-13

Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding

From: Gyungoh Yoo <hidden>
Date: 2014-11-06 04:45:52
Also in: lkml

On Mon, Nov 03, 2014 at 10:45:39PM +0100, Paul Bolle wrote:
On Fri, 2014-10-31 at 16:44 +0000, Mark Brown wrote:
quoted
On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyungoh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
quoted
From: Gyungoh Yoo <redacted>

Signed-off-by: Gyungoh Yoo <redacted>
This doesn't apply against current code and depends on the MFD symbol
rename - can you please check what's going on here?

It would make sense to split the Kconfig symbol rename into a separate
patch to ease merging,
The relicensing (from GPL to GPL v2, thus dropping the "or later"
provision) is odd too. The header still uses GPL v2 or later, doesn't
it? Anyhow, that could be a separate patch too.
I will modify the licensing text and resubmit it.
Thank you for your comment.
quoted
it doesn't seem obviously related to the driver
change and should probably be in the same patch as the MFD symbol rename
for bisetion.
I don't think there will be bisection problems (in mainline). Currently
this driver depends on SKY81452. But that symbol doesn't exist. Only
after both 1/8 and this patch will this driver become buildable, for the
first time. So it's not that this driver was buildable, became
unbuildable in 1/8 and buildable again in this patch.

(I don't think it's much of a problem that the regulator driver got
merged, in v3.18-rc1, before the mfd driver on which it depends.
Avoiding that temporarily problem appears to be more trouble than it's
worth.)


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help