On Fri, Oct 17, 2014 at 12:17:34PM +0200, Mark Brown wrote:

On Fri, Oct 17, 2014 at 06:19:50PM +0900, Gyungoh Yoo wrote:

quoted

Wow. I understand.
I missed .supply_name. I think I need something like
below, before devm_regulator_register().

quoted

	config->supply_name = init_data->constraints.name;

quoted

I will resubmit it.

No, not supply_name (though you really should be initializing that
anyway) and you definitely don't want to set supply_name to something
from constraints.  The supply_name should be the name of the input pin
that supplies power to the regulator.  I was referring to of_match and
regulators_node.

Wow. I had misunderstanding.

Are you talking about simplification using of_regulator_match()?
This driver has only one regulator.
Is the API also useful for this driver?
Like reg-fixed-voltage, how about using of_get_fixed_voltage_config()?

Thanks.