Thread (14 messages) 14 messages, 3 authors, 2014-10-21

Re: [PATCH V2 4/9] Documentation: DT: Add entries for bcm63xx UART

From: Arnd Bergmann <arnd@arndb.de>
Date: 2014-10-21 05:49:51
Also in: linux-mips, linux-serial

On Monday 20 October 2014 15:53:53 Florian Fainelli wrote:
quoted hunk ↗ jump to hunk
For now, I suppose that s simple fix could be to use an anonymous clock
request when probed via DT. This code you quote dates from 2008 when
there was no clkdev in the kernel at all. So something like this would
probably do it for now:
diff --git a/drivers/tty/serial/bcm63xx_uart.c
b/drivers/tty/serial/bcm63xx_uart.c
index e0b87d507670..1b914b85dd31 100644
--- a/drivers/tty/serial/bcm63xx_uart.c
+++ b/drivers/tty/serial/bcm63xx_uart.c
@@ -819,7 +819,7 @@ static int bcm_uart_probe(struct platform_device *pdev)
        if (!res_irq)
                return -ENODEV;

-       clk = clk_get(&pdev->dev, "periph");
+       clk = clk_get(&pdev->dev, pdev->dev.of_node ? NULL : "periph");
        if (IS_ERR(clk))
                return -ENODEV;
Yes, that would work. Just make sure the same bug doesn't creep in
for other drivers you are converting.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help