Thread (14 messages) 14 messages, 3 authors, 2014-10-21

Re: [PATCH V2 4/9] Documentation: DT: Add entries for bcm63xx UART

From: Arnd Bergmann <arnd@arndb.de>
Date: 2014-10-20 21:20:08
Also in: linux-mips, linux-serial

On Monday 20 October 2014 13:54:03 Kevin Cernekee wrote:
+- clock-names: The appropriate output name in the referenced clock node.
+
+       uart0: serial@14e00520 {
+               compatible = "brcm,bcm6345-uart";
+               reg = <0x14e00520 0x18>;
+               interrupt-parent = <&periph_intc>;
+               interrupts = <2>;
+               clocks = <&periph_clk>;
+               clock-names = "periph";
+       };
+
+       clocks {
+               periph_clk: periph_clk@0 {
+                       compatible = "fixed-clock";
+                       #clock-cells = <0>;
+                       clock-frequency = <54000000>;
+                       clock-output-names = "periph";
+               };
+       };
In this example, the clock output name of the clock provider is
the same as the clock input of the consumer, that is almost always
a bug and would not be a good example at all.

I assume the output name is correct and the input is not. If you
have access to the HDL source of the bcm6345-uart, please check
if the input has a proper name, otherwise just call it "uart"
or remove the clock-names property completely.

In the documentation enough, you must document the specific name
of the clock that is supposed to be used by the uart driver.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help