Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator
From: Herbert Xu <hidden>
Date: 2014-10-31 08:18:48
Also in:
linux-arm-kernel, linux-crypto, lkml
From: Herbert Xu <hidden>
Date: 2014-10-31 08:18:48
Also in:
linux-arm-kernel, linux-crypto, lkml
On Fri, Oct 31, 2014 at 09:13:23AM +0100, Maxime Ripard wrote:
I don't understand here. Why would other drivers *not* being affected? If the scatter list passed by AF_ALG can be in highmem, I guess it's the case for every driver out there. Almost every kernel code I've seen so far makes the assumption that the memory it has is mapped and accessible. Somehow, it's the driver's fault now, and not the part of kernel that actually does the allocation?
If you are implementing a crypto driver that is meant to handle requests from the crypto API then yes you need to handle highmem. As I said if enough drivers are unable to address highmem and require copying/software fallbacks then we could provide this through the API and the driver would then only need to declare its lack of highmem support or use a helper. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html