Thread (113 messages) 113 messages, 7 authors, 2014-10-30

Re: [PATCH 09/12] rtc: omap: add support for pmic_power_en

From: Johan Hovold <johan@kernel.org>
Date: 2014-10-22 10:21:54
Also in: linux-arm-kernel, linux-omap, lkml

On Fri, Oct 10, 2014 at 01:07:27PM -0500, Felipe Balbi wrote:
On Thu, Oct 09, 2014 at 09:06:31PM +0200, Johan Hovold wrote:
quoted
-	/* clear pending irqs, and set 1/second periodic,
-	 * which we'll use instead of update irqs
+	/*
+	 * disable interrupts
+	 *
+	 * NOTE: ALARM2 is not cleared on AM3352 if rtc_write (writeb) is used
 	 */
-	rtc_write(0, OMAP_RTC_INTERRUPTS_REG);
+	rtc_writel(0, OMAP_RTC_INTERRUPTS_REG);
bug fix, should be part of a separate patch and Cc stable :-)
I made this a separate fix in v2 but did not mark it for stable for now
as no one has been bitten by it (ALARM2 is never enabled by the current
driver).

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help