Hi,

On Sun, Oct 12, 2014 at 08:42:40PM +0200, Johan Hovold wrote:

On Sat, Oct 11, 2014 at 07:50:07PM -0500, Felipe Balbi wrote:

quoted

Hi,

On Sat, Oct 11, 2014 at 12:20:04PM +0200, Johan Hovold wrote:

quoted

On Fri, Oct 10, 2014 at 01:02:56PM -0500, Felipe Balbi wrote:

quoted

On Fri, Oct 10, 2014 at 01:00:54PM -0500, Felipe Balbi wrote:

quoted

On Thu, Oct 09, 2014 at 09:06:29PM +0200, Johan Hovold wrote:

quoted

Some legacy RTC IP revisions has a power-up reset flag in the status
register that later revisions lack.

As this flag is always read back as set on later revisions (or is
overloaded with a different flag), make sure to only clear the flag and
print the info message on legacy platforms.

Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Felipe Balbi <redacted>

oh, btw. This should be done for DT probes too.

What do you mean? This is for DT probes (of "ti,da830-rtc" and
"ti,am3352-rtc"). DT probing of legacy RTC IPs is currently not
supported.

Are you suggesting I should add a new compatible string for that?

it seemed to me that you're only passing the new flag through
platform_device_id table, not DT table. Did I miss something ?

Ah, that's just the way the driver currently encodes the IP revision
differences. The platform_device_id entries are references from
of_device_id data. Should probably clean that up as well.

oh, alright :-)

Thanks again for the review. I'll post a new version when I'm back from

no problem.

-- 
balbi