RE: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver
From: Chen, Alvin <hidden>
Date: 2014-09-11 00:32:16
Also in:
linux-gpio, lkml
From: Chen, Alvin <hidden>
Date: 2014-09-11 00:32:16
Also in:
linux-gpio, lkml
Hi Alvin, I did a quick test and this looks like it works for me (with device tree). I had a couple of small fixes below.
It is very appreciated to help testing.
Alanquoted
- port->bgc.gc.ngpio = ngpio; - port->bgc.gc.of_node = port_np; +#ifdef CONFIG_OF_GPIO + port->bgc.gc.of_node = pp->node; +#endifPlease use 'if (IS_ENABLED(CONFIG_OF_GPIO)) as a conditional as you do elsewhere.
OK.
quoted
static int dwapb_gpio_probe(struct platform_device *pdev) { + int i; struct resource *res; struct dwapb_gpio *gpio; - struct device_node *np; int err; - unsigned int offs = 0; + struct device *dev = &pdev->dev; + struct dwapb_platform_data *pdata = dev_get_platdata(dev); + bool is_pdata_alloc = !pdata;Please combine the int's in one line (int err, i;) and put them as the last one on this list. It looks the same to the compiler of course, but more uniform for human eyes :)
OK.