Re: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver
From: Darren Hart <dvhart@infradead.org>
Date: 2014-09-09 17:06:34
Also in:
linux-gpio, lkml
On 9/9/14, 11:07, "Weike Chen" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The Synopsys DesignWare APB GPIO driver only supports open firmware devices. But, like Intel Quark X1000 SOC, which has a single PCI function exporting a GPIO and an I2C controller, it is a Multifunction device. This patch is to enable the current Synopsys DesignWare APB GPIO driver to support the Multifunction device which exports the designware GPIO controller. Reviewed-by: Hock Leong Kweh <redacted> Signed-off-by: Weike Chen <redacted> --- drivers/gpio/Kconfig | 1 - drivers/gpio/gpio-dwapb.c | 226 ++++++++++++++++++++++-------- include/linux/platform_data/gpio-dwapb.h | 32 +++++ 3 files changed, 201 insertions(+), 58 deletions(-) create mode 100644 include/linux/platform_data/gpio-dwapb.hdiff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 9de1515..8250a44 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig@@ -136,7 +136,6 @@ config GPIO_DWAPBtristate "Synopsys DesignWare APB GPIO driver" select GPIO_GENERIC select GENERIC_IRQ_CHIP - depends on OF_GPIO
You cover this specific dependencies with inline ifdefs, but you lose the CONFIG_OF depends by dropping it, and there are no such checks in the probe routine. Assumptions of OF are not limited to probe in this driver. While I would like to see this assumption properly abstracted, the most expedient/immediate fix is probably to add a depends on OF above. -- Darren Intel Open Source Technology Center