Thread (2 messages) 2 messages, 2 authors, 2014-08-01

Re: [PATCH 2/2] clk: initial clock driver for TWL6030

From: Mike Turquette <hidden>
Date: 2014-07-31 19:20:53
Also in: linux-arm-kernel

Possibly related (same subject, not in this thread)

Quoting Stefan Assmann (2014-07-31 07:05:43)
On 31.07.2014 14:58, Peter Ujfalusi wrote:
quoted
On 07/31/2014 03:54 PM, Stefan Assmann wrote:
quoted
quoted
Why would you do this? The point of a clock provider is that you can
enable/disable the clock on demand. Here you enable the clock and leave it
enabled for the rest of the time...

clk-dra7-atl deals with similar issue
The idea is to enable the clock by default to get the wifi working.
Sorry if I got it wrong.
You should have a clock driver for the 32K clock. The wifi driver should
request and manage it's clocks via the clock API.
If the clock does not get enabled the wifi driver wl12xx doesn't even
get probed. Which is my initial problem. Maybe I need to figure that out
first.
Sounds like the wifi driver's probe is missing something like:

"""
#include <linux/clk.h>

int ret;

struct clk *clk32k = clk_get(...);

if (IS_ERR(clk32k))
        explode();

ret = clk_prepare_enable(clk32k);

if (ret)
        explode();
"""

Regards,
Mike
  Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help