Re: [PATCH 2/2] clk: initial clock driver for TWL6030
From: Tero Kristo <hidden>
Date: 2014-07-31 13:16:17
Also in:
linux-arm-kernel
Possibly related (same subject, not in this thread)
- 2014-08-01 · Re: [PATCH 2/2] clk: initial clock driver for TWL6030 · Mark Brown <hidden>
- 2014-08-01 · Re: [PATCH 2/2] clk: initial clock driver for TWL6030 · Stefan Assmann <hidden>
- 2014-07-31 · Re: [PATCH 2/2] clk: initial clock driver for TWL6030 · Mike Turquette <hidden>
- 2014-07-31 · Re: [PATCH 2/2] clk: initial clock driver for TWL6030 · Mike Turquette <hidden>
- 2014-07-31 · Re: [PATCH 2/2] clk: initial clock driver for TWL6030 · Stefan Assmann <hidden>
<snip>
quoted
quoted
+static int of_twl6030_clk32kg_probe(struct platform_device *pdev) +{ + struct device_node *node = pdev->dev.of_node; + struct clk *clk; + + if (!node) + return -ENODEV; + + clk = devm_clk_get(&pdev->dev, "clk32kg"); + if (IS_ERR(clk)) + return PTR_ERR(clk); + + return clk_prepare(clk);This is plain wrong as pointed out earlier. The driver that uses the clock must enable it.Understood. I'll change it to clk_prepare_enable().
Nono, remove it completely from here. The clock driver should not enable itself by default. The clock itself has some sort of customer somewhere (like am33xx-wifi driver), which should request for the clock and enable it only when needed. -Tero -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html