Re: [PATCH] ARM: at91: spi: request all csgpio in spi probe
From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2014-07-31 17:24:42
Also in:
linux-arm-kernel, lkml
On Aug 1, 2014, at 12:48 AM, Alexandre Belloni [off-list ref] wrote:
On 01/08/2014 at 00:10:05 +0800, Jean-Christophe PLAGNIOL-VILLARD wrote :quoted
quoted
quoted
quoted
While this solves the particular issue Jiří is seeing, this will not solve the case where PA14 (CS0) is not used by the spi driver at all. It will remained muxed as CS0 and toggle when the spi master needs to access CS0 until another driver muxes it to something else. I still believe we should explicitly ask pinctrl to mux them as gpios.This is not the job of the kernel but to the bootloader no the pinctrl binding is not here and will never be here the configure a pin as a GPIO orThis is exactly what AT91_PERIPH_GPIO does though. Anyway, not request the pinmuxing in the driver is not a good idea, then nothing prevents another driver to request them to do something completely different.
here it’s the same issue if you need to pin as GPIO use the GPIO API not the pinctrl AT91_PERIPH_GPIO is use the set specific pinmux (bouncing & etc…)
quoted
to a specific state. This the job of the driver or the bootloaderI agree that it must not allow to set the state, we are talking about muxing. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel