Re: [PATCH v7 07/24] mfd: max77686: Remove unneeded OOM error message
From: Lee Jones <hidden>
Date: 2014-07-18 08:19:05
Also in:
linux-arm-kernel, linux-samsung-soc, lkml
On Fri, 04 Jul 2014, Javier Martinez Canillas wrote:
There is no need to print out-of-memory errors since this is already done by the memory management subsystem which even calls dump_stack(). Signed-off-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8rSCDK34cm6iQ@public.gmane.org.uk> --- drivers/mfd/max77686.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Applied now, thanks.
quoted hunk ↗ jump to hunk
diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index 87fe52e..8650832 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c@@ -107,10 +107,8 @@ static struct max77686_platform_data *max77686_i2c_parse_dt_pdata(struct device struct max77686_platform_data *pd; pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); - if (!pd) { - dev_err(dev, "could not allocate memory for pdata\n"); + if (!pd) return NULL; - } dev->platform_data = pd; return pd;
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html