[PATCH v7 05/24] mfd: max77686: Return correct error when pdata isn't found
From: Javier Martinez Canillas <hidden>
Date: 2014-07-04 20:25:20
Also in:
linux-arm-kernel, linux-samsung-soc, lkml
Subsystem:
maxim pmic and muic drivers for exynos based boards, multifunction devices (mfd), the rest · Maintainers:
Chanwoo Choi, Krzysztof Kozlowski, Lee Jones, Linus Torvalds
When platform data is not found an -EIO (I/O error) code is returned. This doesn't seem to be the correct error so better return -EINVAL (Invalid argument) which is what most drivers do in this case. Signed-off-by: Javier Martinez Canillas <redacted> --- drivers/mfd/max77686.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
index 12d4c17..ada4976 100644
--- a/drivers/mfd/max77686.c
+++ b/drivers/mfd/max77686.c@@ -129,7 +129,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c, if (!pdata) { dev_err(&i2c->dev, "No platform data found.\n"); - return -EIO; + return -EINVAL; } max77686 = devm_kzalloc(&i2c->dev,
--
2.0.0.rc2