Re: [PATCH 1/2 v3] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

On Wed, Jun 11, 2014 at 11:53:30PM +0530, Naveen Krishna Ch wrote:

On 11 June 2014 23:20, Tomasz Figa [off-list ref] wrote:

quoted

- in DT case, don't do anything in the driver about the GPIO chip
select, because it will be handled automatically by the core.

But, i see that gpio_request_one is needed in _setup function in the driver.
Except that no other gpio related operation is needed in the driver.

Ideally this code could be moved into the core too - indeed, ideally the
non-DT case could be handled by the core too except for the bit where we
look up what GPIO to use.