Re: [PATCH v2 3/8] PCI: designware: update pcie core driver to work with dw hw version 3.65

On Friday 20 June 2014 01:27 PM, Murali Karicheri wrote:

On 6/18/2014 3:13 AM, Mohit KUMAR DCG wrote:

quoted

Hello Murali,

quoted

-----Original Message-----
From: Murali Karicheri [mailto:m-karicheri2@ti.com]
Sent: Wednesday, June 11, 2014 12:21 AM
To: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-
doc@vger.kernel.org
Cc: Murali Karicheri; Santosh Shilimkar; Russell King; Grant Likely; Rob Herring;
Mohit KUMAR DCG; Jingoo Han; Bjorn Helgaas; Pratyush ANAND; Richard
Zhu; Kishon Vijay Abraham I; Marek Vasut; Arnd Bergmann; Pawel Moll;
Mark Rutland; Ian Campbell; Kumar Gala; Randy Dunlap
Subject: [PATCH v2 3/8] PCI: designware: update pcie core driver to work
with dw hw version 3.65

v3.65 version of the dw hw has MSI controller implemented in the application
space. Add a version variable in the port struct to identify v3.65 hardware for
different code treatment. This variable will have DW_V3_65 bit set when
running on this hw version. The host init code is expected to set this version
based on compatibility string dw,snps-pcie-v3.65.

Some of the MSI specific functions from current DW driver are re-used on
v3.65 hw. However on v3.65, MSI controller registers are in the application
register space and PCIE_MSI_INTR0_ENABLE is not applicable.
Modify assign_irq() to check for version and not execute the code for
PCIE_MSI_INTR0_ENABLE configuration on v3.65 hw. Additionally MSI IRQ
register in application space is written by EP to raise an MSI IRQ. So add a
get_msi_data() function in pcie_host_ops to retrieve the register address in
dw_msi_setup_irq(). v3.65 dw core driver implements this function.

Also make some of the functions available in dw core driver global and make
their prototypes available in the header file for re-use on v3.65.

- Pls apply MSI specific changes on the top of Lucas patches:
[PATCH 0/4] proper multi MSI handling for designware host

Thanks
Mohit

Ok. I have pulled in Lucas's patches and use it for my work.

Are those patches already acked and getting into the queue. Please
don't create UN-necessary merge dependencies otherwise.

regards,
Santosh