Thread (24 messages) 24 messages, 2 authors, 2014-05-27

Re: [PATCHv5 09/10] DTS: ARM: OMAP3-N900: Add SSI support

From: Sebastian Reichel <sre@kernel.org>
Date: 2014-05-22 00:06:07
Also in: linux-omap, lkml

Hi,

On Wed, May 21, 2014 at 03:08:07PM -0700, Tony Lindgren wrote:
* Sebastian Reichel [off-list ref] [140521 14:51]:
quoted
On Wed, May 21, 2014 at 12:45:28PM -0700, Tony Lindgren wrote:

Right. The only documentation of the SSI module is existing
code sent by Carlos / included in the maemo kernel.
That's probably better than any documentation though :)
Both have their advantages. Just with the code its hard to add
features like context loss checks.
quoted
quoted
quoted
It's probably something with the sysc or idlemodes that
keeps things from idling. Maybe wrong address? Or wrong
flags? I'm pretty sure it was the first .dts patch out of
these two as the second one alone did not apply.
Hmm yeah below is probably how it should be, does this
work for you? With this fix applied and your ssi dts
patches n900 keeps hitting off-idle for me.
I can confirm, that the N900 hits idle states when the DT
patch and the hwmod patch is applied. I have not actually
tested if it also works without your hwmod patch.

There are still problems with the idle state if the driver is
actually loaded (and I see 100% runtime pm usage in powertop),
but that can be fixed later.

Feel free to add Tested-by/Acked-By to the hwmod patch.
OK thanks for testing.
You are welcome.
I'll apply your dts changes as soon as I have an ack from Paul on
the hwmod changes. Probably best to queue them together to avoid
PM breaking.
Ok. Sounds legit.

-- Sebastian

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help