Re: [PATCH v7 3/10] Documentation: devicetree: Update Samsung FIMC DT binding
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2014-03-11 16:20:35
Also in:
linux-media
Hi Sylwester, Thank you for the patch. On Tuesday 11 March 2014 17:00:35 Sylwester Nawrocki wrote:
quoted hunk ↗ jump to hunk
This patch documents following updates of the Exynos4 SoC camera subsystem devicetree binding: - addition of #clock-cells and clock-output-names properties to 'camera' node - these are now needed so the image sensor sub-devices can reference clocks provided by the camera host interface, - dropped a note about required clock-frequency properties at the image sensor nodes; the sensor devices can now control their clock explicitly through the clk API and there is no need to require this property in the camera host interface binding. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Resending only single patch which changed. Changes since v6: - #clock-cells, clock-output-names documented as mandatory properties; - renamed "cam_mclk_{a,b}" to "cam_{a,b}_clkout in the example dts, this now matches changes in exynos4.dtsi further in the patch series; - marked "samsung,camclk-out" property as deprecated. Changes since v5: - none. Changes since v4: - dropped a requirement of specific order of values in clocks/ clock-names properties (Mark) and reference to clock-names in clock-output-names property description (Mark). --- .../devicetree/bindings/media/samsung-fimc.txt | 46 +++++++++++++------- 1 file changed, 31 insertions(+), 15 deletions(-)diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txtb/Documentation/devicetree/bindings/media/samsung-fimc.txt index 96312f6..1908a5f 100644--- a/Documentation/devicetree/bindings/media/samsung-fimc.txt +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt
[snip]
quoted hunk ↗ jump to hunk
Image sensor nodes ------------------@@ -97,8 +108,8 @@ Image sensor nodes The sensor device nodes should be added to their control bus controller(e.g. I2C0) nodes and linked to a port node in the csis or the parallel-ports node, using the common video interfaces bindings, defined in video-interfaces.txt. -The implementation of this bindings requires clock-frequency property to be -present in the sensor device nodes. +An optional clock-frequency property needs to be present in the sensor device +nodes. Default value when this property is not present is 24 MHz.
I think you forgot to drop that sentence. -- Regards, Laurent Pinchart