Thread (27 messages) 27 messages, 7 authors, 2014-03-18

Re: [PATCH v6 01/10] Documentation: dt: Add binding documentation for S5K6A3 image sensor

From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Date: 2014-03-06 20:15:42
Also in: linux-arm-kernel, linux-media, linux-samsung-soc

Hi Phillip,

On 03/06/2014 07:08 PM, Philipp Zabel wrote:
quoted
+++ b/Documentation/devicetree/bindings/media/samsung-s5k6a3.txt
quoted
 @@ -0,0 +1,33 @@
 +Samsung S5K6A3(YX) raw image sensor
 +---------------------------------
 +
 +S5K6A3(YX) is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces
 +and CCI (I2C compatible) control bus.
 +
 +Required properties:
 +
 +- compatible   : "samsung,s5k6a3";
 +- reg          : I2C slave address of the sensor;
 +- svdda-supply : core voltage supply;
 +- svddio-supply        : I/O voltage supply;
 +- afvdd-supply : AF (actuator) voltage supply;
 +- gpios                : specifier of a GPIO connected to the RESET pin;
Please use 'reset-gpios' for GPIOs connected to reset pins.
I would prefer to keep it as is, I'm not adding a new driver in this
series, just the binding documentation and doing some refactoring.
So if I changed this now, the driver would need to be messed up with
an additional code to support both 'gpios' and 'reset-gpios'. Are
there any serious reasons to use this specific name ? It's not
related to the reset signal DT bindings, is it ?

--
Regards,
Sylwester
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help