Thread (24 messages) 24 messages, 8 authors, 2014-04-16

Re: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible

From: Lucas Stach <l.stach@pengutronix.de>
Date: 2014-03-06 17:39:15
Also in: linux-arm-kernel, linux-pci, linux-samsung-soc, linux-sh, linux-tegra

Am Donnerstag, den 06.03.2014, 10:36 -0700 schrieb Stephen Warren:
On 03/05/2014 06:25 AM, Lucas Stach wrote:
quoted
This is the recommended method of doing the IRQ
mapping. For old devicetrees we fall back to the
previous practice.
Tested-by: Stephen Warren <redacted>

I tested both with and without patch 1/6, and the PCIe-based NIC on
Beaver worked fine either way. Without patch 1/6, I do see:

pci 0000:00:01.0: of_irq_parse_pci() failed with rc=-22

... but that seems reasonable given that the DT that of_irq_parse_pci()
parses is missing, and did correctly trigger the fallback path, so
everything still worked.
Yes, this should be normal. It spits this error for old DTs, but keeps
doing the right thing. I'm not sure if we should downgrade this to info
or dbg.

Regards,
Lucas
-- 
Pengutronix e.K.                           | Lucas Stach                 |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help