Thread (24 messages) 24 messages, 8 authors, 2014-04-16

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

From: Jason Gunthorpe <hidden>
Date: 2014-03-05 18:42:19
Also in: linux-arm-kernel, linux-pci, linux-samsung-soc, linux-sh, linux-tegra

On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote:
-	return pp->irq;
+	irq = of_irq_parse_and_map_pci(dev, slot, pin);
+	if (!irq)
+		irq = pp->irq;
In light of the two bugs that Tim found, it might be wise to throw a
'dev_warn(FW_BUG "Missing DT interrupt mapping")' in the fall back
path, so it doesn't continue to silently cover up errors on the OF/DT
side..

Regards,
Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help