Re: [PATCH 6/6] documentation: bindings: document PMIC8921/8058 RTC

On Wed, Mar 05, 2014 at 05:31:27PM -0800, Stephen Boyd wrote:

On 03/05/14 16:00, Josh Cartwright wrote:

quoted

On Wed, Mar 05, 2014 at 12:58:55PM -0800, Stephen Boyd wrote:

quoted

On 03/05/14 11:29, Josh Cartwright wrote:

quoted

diff --git a/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt b/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt
new file mode 100644
index 0000000..699bd30
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt

@@ -0,0 +1,29 @@
+* Real-Time Clock for Qualcomm 8058/8921 PMICs
+
+Required properties:
+- compatible: should be one of the following.
+    * "qcom,pm8058-rtc"
+    * "qcom,pm8921-rtc"
+- reg: base address of the register region
+- reg-names: corresponding reg names for the regions listed in the 'reg'
+             property, must contain:
+     "rtc_base" - base of the RTC register region

optional reg-names?

quoted

+- interrupts: interrupt list for the RTC, must contain a single interrupt
+              specifier for the alarm interrupt
+- interrupt-names: corresponding interrupt names for the interrupts listed in
+                   the 'interrupts' property, must contain:
+     "alarm" - summary interrupt for PMIC peripherals

optional interrupt-names?

It isn't clear to me why these should be made optional, I hope Rob
provides some clarification in the sdhci-msm thread.

Looks like the driver isn't using either of these properties, so I'm not
sure why they're needed. Maybe they should just be removed.

The driver does make use of platform_get_irq_byname(pdev, "alarm"), and
I expect to make use of platform_get_resource_byname(pdev, IORESOURCE_REG, "rtc_base")
in the near future.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation