Re: [PATCH V9 2/2] ARM: dts: Enable ahci sata and sata phy

On Tuesday, March 04, 2014 1:02 AM, Kumar Gala wrote:

On Mar 3, 2014, at 5:59 AM, Kishon Vijay Abraham I [off-list ref] wrote:

quoted

On Monday 03 March 2014 10:52 AM, Yuvaraj Kumar C D wrote:

quoted

This patch adds dt entry for ahci sata controller and its
corresponding phy controller.phy node has been added w.r.t
new generic phy framework.

Signed-off-by: Yuvaraj Kumar C D <redacted>

This should go via exynos dt tree.

FWIW
Acked-by: Kishon Vijay Abraham I <redacted>

quoted

-

Its a nit, but the subject really should have 'exynos' or some related qualifier. 
We aren't enabling ahci sata & phy for all of ARM

I agree with your opinion.
The subject should be fixed in order to get rid of confusion.

For example, one of the followings looks good.

  ARM: dts: exynos5250: Enable ahci sata and sata phy
  ARM: dts: Enable ahci sata and sata phy for exynos5250

Best regards,
Jingoo Han

- k

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation