Re: [PATCH 4/6] regulator: add bcm59056 regulator driver

From
Mark Brown <hidden>
Date
2014-02-04 23:22:35
Also in
linux-arm-kernel, linux-i2c, lkml
Reply to
Matt Porter, 2014-02-04
On Tue, Feb 04, 2014 at 04:29:14PM -0500, Matt Porter wrote:
On Tue, Feb 04, 2014 at 05:28:36PM +0000, Mark Brown wrote:
quoted
quoted
+		/*
+		 * Regulator API handles empty constraints but not NULL
+		 * constraints
+		 */
+		if (!reg_data)
+			continue;
quoted
It should do...  if not then make it so since that'd mean most drivers
are buggy.
Ahh, I see there is a check for NULL in the core. Will drop.
It was missing in some older kernels (much older now IIRC) - it's
possible that comment was written before this got fixed.

Attachments

Thread (27 messages) 27 messages, 5 authors, last reply 2014-02-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help