Re: [PATCH v3 3/3] DT: proc: Add runtime overlay interface in /proc

From
Ionut Nicu <hidden>
Date
2013-11-11 10:23:24
Also in
lkml
Reply to
Pantelis Antoniou, 2013-11-08
Hi,

On 08.11.2013 16:06, ext Pantelis Antoniou wrote:
Add a runtime interface to /proc to enable generic device tree overlay
usage.
quoted hunk ↗ jump to hunk
+
+		/* start at 256K at first */
+		if (od->alloc == 0)
+			od->alloc = SZ_256K / 2;
+
Same problem as Guenter reported. I have to include <linux/sizes.h> or otherwise
the code will not build.
quoted hunk ↗ jump to hunk
+	rcu_read_lock();
+	idr_for_each_entry(&overlay_idr, od, id) {
+		seq_printf(m, "%d: %d bytes", id, od->size);
For od->size we should use "%zu", otherwise there will be a compilation warning.
At least I get one on mips64...

Otherwise, I've tested this and it works fine for me also.

Thanks,
Ionut
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thread (22 messages) 22 messages, 5 authors, last reply 2013-11-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help