Re: [PATCH V4 1/3] ARM: dts: Add pmu sysreg node to Exynos5 dtsi file
From: Tomasz Figa <hidden>
Date: 2013-10-30 14:42:47
Also in:
linux-samsung-soc, linux-watchdog
Hi Leela, On Wednesday 30 of October 2013 15:21:11 Leela Krishna Amudala wrote:
quoted hunk ↗ jump to hunk
This patch adds pmusysreg node to Exynos5 dtsi file to handle PMU register accesses in a centralized way using syscon driver Signed-off-by: Leela Krishna Amudala <redacted> --- arch/arm/boot/dts/exynos5.dtsi | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi index e52b038..918e732 100644 --- a/arch/arm/boot/dts/exynos5.dtsi +++ b/arch/arm/boot/dts/exynos5.dtsi@@ -106,4 +106,9 @@ #size-cells = <0>; status = "disabled"; }; + + pmu_sys_reg: pmusysreg@1004000 {
Please keep the node name generic, syscon should be fine. Also there is a typo in unit-address suffix. The label could also have a better name, like pmu_syscon. Best regards, Tomasz
+ compatible = "syscon"; + reg = <0x10040000 0x5000>; + }; };