Re: [PATCHv7][ 1/4] Input: tsc2007: Add device tree support.
From: Lothar Waßmann <hidden>
Date: 2013-10-25 05:56:39
Also in:
linux-arm-kernel, linux-input
Hi, Grant Likely wrote:
On Thu, 24 Oct 2013 14:42:13 +0200, Denis Carikli [off-list ref] wrote:quoted
Cc: Rob Herring <redacted> Cc: Pawel Moll <redacted> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Stephen Warren <redacted> Cc: Ian Campbell <redacted> Cc: devicetree@vger.kernel.org Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-input@vger.kernel.org Cc: Sascha Hauer <kernel@pengutronix.de> Cc: linux-arm-kernel@lists.infradead.org Cc: Lothar Waßmann <redacted> Cc: Eric Bénard <redacted> Signed-off-by: Denis Carikli <redacted> --- ChangeLog v6->v7: - One small whitespace cleanup. - The properties specific to that driver are now prefixed with "ti,". - The ti,fuzzy property has now better documentation. --- .../bindings/input/touchscreen/tsc2007.txt | 45 +++++ drivers/input/touchscreen/tsc2007.c | 194 +++++++++++++++----- 2 files changed, 198 insertions(+), 41 deletions(-) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/tsc2007.txtdiff --git a/Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt b/Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt new file mode 100644 index 0000000..516b63b --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt@@ -0,0 +1,45 @@ +* Texas Instruments tsc2007 touchscreen controller + +Required properties: +- compatible: must be "ti,tsc2007". +- reg: I2C address of the chip. +- ti,x-plate-ohms: X-plate resistance in ohms. + +Optional properties: +- gpios: the interrupt gpio the chip is connected to (trough the penirq pin) + (see GPIO binding[2] for more details).Hmmm, why is this needed? Is the line used for anything other than finding the irq number? If it is just an interrupt then an interrupts property is all that should be specified.
It's also the pendown detect GPIO. It asserts an interrupt when first activated and is then polled in the driver until it goes inactive again. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel