Re: [PATCH v4 4/7] ARM: dts: add dt nodes for exynos5420 hdmi subsystem
From: Tomasz Figa <hidden>
Date: 2013-08-23 19:48:41
Also in:
linux-samsung-soc
Hi Rahul, Please see my comments inline. On Friday 23 of August 2013 15:54:18 Rahul Sharma wrote:
quoted hunk ↗ jump to hunk
Add hdmi, mixer, ddc device tree nodes for Exynos 5420 SoC. Signed-off-by: Rahul Sharma <redacted> --- arch/arm/boot/dts/exynos5420-smdk5420.dts | 19 +++++++++++++++++++ arch/arm/boot/dts/exynos5420.dtsi | 14 ++++++++++++++ 2 files changed, 33 insertions(+)diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dtsb/arch/arm/boot/dts/exynos5420-smdk5420.dts index bafba25..7dbf1fa 100644--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts@@ -61,4 +61,23 @@ }; }; + hdmi@14530000 { + status = "okay"; + hpd-gpio = <&gpx3 7 0>; + }; + + mixer@14450000 { + status = "okay"; + }; + + i2c_2: i2c@12C80000 { + samsung,i2c-sda-delay = <100>; + samsung,i2c-max-bus-freq = <66000>; + status = "okay"; + + hdmiddc@50 { + compatible = "samsung,exynos4210-hdmiddc"; + reg = <0x50>; + }; + }; };
You should separate above board-specific changes from this patch and squash it with patch 6/7, adjusting patch subject and description appropriately.
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/boot/dts/exynos5420.dtsib/arch/arm/boot/dts/exynos5420.dtsi index 05dee86..7c6214d 100644--- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi@@ -274,4 +274,18 @@ pinctrl-0 = <&i2c3_bus>; status = "disabled"; }; + + hdmi@14530000 { + compatible = "samsung,exynos4212-hdmi"; + reg = <0x14530000 0x70000>; + interrupts = <0 95 0>; + status = "disabled"; + }; + + mixer@14450000 { + compatible = "samsung,exynos5420-mixer"; + reg = <0x14450000 0x10000>; + interrupts = <0 94 0>; + status = "disabled";
This node looks like a candidate to be enabled here on SoC level, since it does not require any board specific information. Best regards, Tomasz