Thread (12 messages) 12 messages, 3 authors, 2013-08-13

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

From: Ohad Ben-Cohen <hidden>
Date: 2013-08-10 19:12:20
Also in: linux-arm-msm, lkml

+ Grant

On Thu, Aug 1, 2013 at 5:10 PM, Kumar Gala [off-list ref] wrote:
quoted
On Jul 29, 2013, at 4:40 PM, Stephen Boyd wrote:
quoted
On 07/29, Kumar Gala wrote:
quoted
quoted
diff --git a/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt b/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt
new file mode 100644
index 0000000..ddd6889
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt
Maybe this should go under a new hwspinlock directory?
Will look for Ohad to comment on this.
quoted
quoted
quoted
@@ -0,0 +1,20 @@
+Qualcomm MSM Hardware Mutex Block:
+
+The hardware block provides mutexes utilized between different processors
+on the SoC as part of the communication protocol used by these processors.
+
+Required properties:
+- compatible: should be "qcom,tcsr-mutex"
+- reg: Should contain registers location and length of mutex registers
+- reg-names:
+  "mutex-base"  - string to identify mutex registers
+- qcom,num-locks: the number of locks/mutexes supported
+
+Example:
+
+  qcom,tcsr-mutex@fd484000 {
Maybe it should be hw-mutex@fd484000?
again, will look for Ohad to make some comment on this.
quoted
quoted
quoted
+          compatible = "qcom,tcsr-mutex";
+          reg = <0xfd484000 0x1000>;
+          reg-names = "mutex-base";
+          qcom,num-locks = <32>;
+  };
Ohad, ping.
I'd prefer a DT maintainer to take a look at your two open questions
above, especially if I'm to merge a new file into the devicetree
Documentation folder.

Grant, any chance you have a moment to take a look?

Otherwise, Stephen - do we have your Ack here? I was happy to see your
review but not sure what's the latest status.

Thanks,
Ohad.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help