Re: [PATCH 1/5] sata, highbank: fix ordering of SGPIO signals
From: Mark Langsdorf <hidden>
Date: 2013-08-02 15:24:53
Also in:
linux-ide, lkml
From: Mark Langsdorf <hidden>
Date: 2013-08-02 15:24:53
Also in:
linux-ide, lkml
On 07/29/2013 11:55 AM, Tejun Heo wrote:
On Fri, Jul 26, 2013 at 10:11:54AM -0500, Mark Langsdorf wrote:quoted
The ACTIVITY and ERROR signals were reversed in the original commit. Fix that.And what's the implication of this change? Does this change the behavior of the driver? If so, how? If not, why not? *Please* be more descriptive in patch descriptions and explain *why* the changes are being made.
I didn't think I needed more of an explanation than "this is completely wrong per the spec" but I'll revise and resubmit. --Mark Langsdorf Calxeda, Inc.