Re: [PATCH 1/2] pinctrl: pinconf_generic: add utility functions for add map/configs

On 07/27/2013 04:14 AM, Laxman Dewangan wrote:

On Friday 26 July 2013 11:06 PM, Stephen Warren wrote:

quoted

On 07/26/2013 04:15 AM, Laxman Dewangan wrote:

quoted

Some of pincontrol driver needs the utility function to create map
list. The utility function needed for adding mux, configs etc.

Which other drivers already contain this code? Are you planning on
converting them over to use these new functions? The code looks
familiar, so I assume it's just cut/paste from Tegra with some renames,
so I didn't read it through in detail.

Yes, these functions are taken from the pinctrl-tegra driver. Other
drivers which have similar implementation are nomadik, tegra, abx500,
tz1090, tz1090-pdc.
So All can use these utility function to avoid duplication and reduce
code size.
Yes, I have plan to use this in Tegra atleast but once this patch get
accepted.

quoted

quoted

  drivers/pinctrl/pinconf-generic.c       |  105
+++++++++++++++++++++++++++++++
  include/linux/pinctrl/pinconf-generic.h |   52 +++++++++++++++

I don't think those are the correct files for this code. Presumably
there's no reason at all why a pinctrl driver that doesn't require
CONFIG_GENERIC_PINCONF can't use these basic utility functions. Perhaps
add a new pinctrl-utils file?

I thought generic implementation of parsing of dt is pinctrl-generic
file and as these newly added APIs are require for the parsing the DT
node, I added here.
I can move this to pinctrl-util.c/h also.

pinctrl-generic isn't about DT, it's about defining generic options for
pin configuration rather than SoC-/driver-specific options for pin
configuration. (pin configuration being e.g. pull-up/down, bias
direction/strength, slew rate, etc.)