Re: [PATCH 3/4] GPIO: Add TB10x GPIO driver
From: Stephen Warren <hidden>
Date: 2013-06-19 22:37:23
Also in:
lkml
On 06/18/2013 03:29 AM, Christian Ruppert wrote:
The GPIO driver for the Abilis Systems TB10x series of SOCs based on ARC700 CPUs. It supports GPIO control and GPIO interrupt generation. This driver works in conjunction with the TB10x pinctrl driver.
Just one comment on the binding (I didn't read the code):
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/gpio/abilis,tb10x-gpio.txt b/Documentation/devicetree/bindings/gpio/abilis,tb10x-gpio.txt
+Required Properties:
+- ngpio: the number of GPIO pins this driver controls.
That's a custom property, so should include a vendor prefix: abilis,ngpios.