Re: [PATCH v4 06/10] s5p-fimc: Use pinctrl API for camera ports configuration
From: Stephen Warren <hidden>
Date: 2013-02-06 23:44:54
Also in:
linux-arm-kernel, linux-media, linux-samsung-soc
On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote:
Before the camera ports can be used the pinmux needs to be configured properly. This patch adds a function to set the camera ports pinctrl to a default state within the media driver's probe(). The camera port(s) are then configured for the video bus operation.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt b/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt
+- pinctrl-names : pinctrl names for camera port pinmux control, at least + "default" needs to be specified. +- pinctrl-0...N : pinctrl properties corresponding to pinctrl-names +
A reference to the binding document describing the pin control bindings would be appropriate here. Given that reference, I'm not sure if spelling out the property names makes sense since it feels a little like duplication; an alternative might be simply: The pinctrl bindings defined in ../../../pinctrl/pinctrl-bindings.txt must be used to define a pinctrl state named "default". However, this isn't a big deal; it's fine either way.