Re: [PATCH v4 01/10] s5p-csis: Add device tree support
From: Stephen Warren <hidden>
Date: 2013-02-06 23:36:39
Also in:
linux-arm-kernel, linux-media, linux-samsung-soc
On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote:
s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC device. This patch support for binding the driver to the MIPI-CSIS devices instantiated from device tree and for parsing all SoC and board specific properties.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/media/soc/samsung-mipi-csis.txt b/Documentation/devicetree/bindings/media/soc/samsung-mipi-csis.txt
+Optional properties: + +- clock-frequency : The IP's main (system bus) clock frequency in Hz, default + value when this property is not specified is 166 MHz;
Shouldn't this be a "clocks" property, so that the driver can call clk_get(), clk_prepare_enable(), clk_get_rate(), etc. on it? Other than that this binding seems fine to me at a quick glance.