Thread (1 message) 1 message, 1 author, 2012-10-15

Re: [PATCH] i2c: i2c-gpio: fix issue when DT node greater than 1

From: Jean Delvare <hidden>
Date: 2012-10-15 06:49:20
Also in: linux-arm-kernel, linux-i2c

Possibly related (same subject, not in this thread)

On Mon, 15 Oct 2012 10:59:19 +0800, Bo Shen wrote:
On 10/10/2012 10:54, Bo Shen wrote:
quoted
On 9/19/2012 23:54, Jean Delvare wrote:
quoted
On Wed, 19 Sep 2012 09:28:04 -0600, Stephen Warren wrote:
quoted
The problematic code appears to be:

snprintf(adap->name, sizeof(adap->name), "i2c-gpio%d", pdev->id);

Instead, I think that should be something more like:

adap->name = dev_name(&pdev->dev);
strlcpy(adap->name, dev_name(&pdev->dev), sizeof(adap->name))
 >> if anything, as adap->name is a buffer, not a pointer.
quoted
I am sorry for late. I have tested with DT, it works.

Please send this patch to fix the issue.
Thanks.
Ping?

Will you send this patch?
Which patch, please? On September 18th, you sent a first version.
Stephen Warren asked you for a change, but you never sent version two
of the patch including the requested change. So don't be surprised if
your patch never got applied.
Or, I send this patch and add your S.O.B, which do you prefer?
I prefer that you send patch v2 and let the interested parties review
and apply it. Do not add S-o-B for anyone else, ever.

Note that i2c-gpio is normally handled by Wolfram Sang, not me.

-- 
Jean Delvare
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help